RF455-057 RF 4.55: several jades do nothing when held (no reader, no effect data, or effect code past 82)

Game server RF Online: Dragonborn v0.2.0 low · filed by cybercyber 14h ago

Fixed

Game: RF 4.55 (Dragonborn), server v0.2.0, Windows build (stock gameserver.exe). Client: the supported Taiwan build, RF_Online.bin SHA-256 46528aac…2bbc558 (2025-07-16), Language=Taiwan.

Summary

These jades sit in the bag and show their tooltip, but holding them changes nothing on the server. There are three causes:

The server folds their effect code, but nothing reads it.
The item row has no effect data at all.
The effect code is 83 or higher, and foldHaveEffects drops those codes.

Read statically from gameserver.exe v0.2.0 and gamedata_rf455.db (resourceitem), not measured in game.

1. Effect code folded, but no reader

(*Server).foldHaveEffects (0x1408523a0) adds these codes into the held-effect array. No reader or combat route uses them, and GoMMO's own route table (gamedata.map.init.1, values at 0x140d39b20) names the 2232 function that used to consume each one.

Jade (code)	Code	Unit / max	Original consumer (from the route table)	What should happen
Lucky Jade (`irjad01`)	0 `gamble_prof`	0.1 / 0.1	none	Gamble/luck ×1.1: is there anything in 4.55 it should feed?
Talk Jade (`irjad04`), Jade of Communication 2/6/24 Hrs (`ircja09`–`11`)	3 `chat_all_race`	1 / 1	`pc_ChatCircleRequest`, `pc_ChatFarRequest`, `pc_ChatMultiFarRequest`	Chat is readable by every race
[Manufacture] Provocation / Fear Jade (`irmak07` / `irmak08`)	28 `aggro`	+5 / −5	`CMonsterAggroMgr::SetAggro`	More / less monster aggro
[Manufacture] Direct Hit Jade (`irmak10`)	48 → `Eff_Plus[40]`	7 / 21	routed to `plus[40]`, which nothing reads	Direct hit / crit bonus
[Manufacture] Reader Jade (`irmak11`)	53 `party`	1 / 5	the six party invitation / application handlers	Party leader / size bonus
[Manufacture] Holy Jade (`irmak12`)	77 `cont_damage_half`	0.3 / 0.3	`CCharacter::InsertSFContEffect` (`DecHalfSFContDam`)	Less damage-over-time damage
Jade of Capture 1% Gain (`irstl01`)	81 `capture_gain`	0.1 / 0.5	none ("No reader and no apply arm (the jump table stops at 80)")	Capture chance +1%

2. No effect data in the item row

Jade	Row
Jade of Capture 3% / 5% / 7% / 9% Gain (`irstl02`–`05`, index 146–149)	`m_nEffectDataNum` 1 but `nEffCode` −1, `fEffUnit` −1. Only the 1% one (`irstl01`) has code 81.

3. Effect code past the fold

foldHaveEffects's inner loop (0x1408528a3) skips any code ≥ 0x53 (cmp r10, 0x53; jae). The fold array has only 83 slots.

Jade	Code	Unit / max
Discount Jade [1 / 7 / 14 / 30 days] (`iramr03`, `05`, `07`, `09`)	85	0.03 / 0.15
Great Discount Jade [1 / 7 / 14 / 30 days] (`iramr04`, `06`, `08`, `10`)	85	0.05 / 0.25

Code 85 isn't in the route table either. By the name it should be a shop discount. In all, 82 resource items carry a code from 85 to 109, and 81 of them have no other code, so they do nothing at all. This report only lists the jades.

Reported on version 0.2.0

Replies 1

OSO AI Staff

Lv 10

Inspect OSO AI

13h ago

Reported: Several jades show their tooltip in the bag but change nothing on the server in 0.2.0: Lucky, Talk / Communication, Provocation, Fear, Direct Hit, Reader, Holy, Capture and the Discount jades.

Found: Most of this is confirmed. The server added up each held jade's effect, but in 0.2.0 nothing read that total for the Talk, Provocation, Fear, Direct Hit and Reader jades; the Discount jades' effect was dropped before anything could read it; and the Holy Jade only shortened harmful effects already on the character when it was picked up. The Fear Jade also never applied at all, which is fixed under RF455-056.

The Lucky Jade is not a defect. It feeds a gambling bonus that the original server never read either, and there is no gamble feature on our server for it to feed, so it stays inert.

Fix: in the next RF 4.55 update:

Talk Jade and Jade of Communication: the holder reads other races' nearby chat and whispers in full, as on the original server.
Provocation Jade: a monster choosing between nearby players picks the holder first.
Fear Jade: a monster passes over the holder while anyone else is in range.
Direct Hit Jade: its bonus adds to the hit chance of every attack (from the hit-roll fix under RF455-052).
Holy Jade: harmful effects that land while it is held are also shortened, as on the original server.
Discount and Great Discount Jades: they lower NPC shop purchase prices, up to the jade's own limit.

The Reader Jade widens the level range allowed between party members. This server has no party level limit, so every player can already join any party and the jade has nothing to widen.

Please file separately:

Jade of Capture (all five): there is no capture feature on our server, so no capture chance exists for any of them to raise, and the 3% to 9% items carry no effect in the item data at all. Adding capture is its own decision, so its own report is what a later change will cite.